Remove example of register a service where its id match to its class #10070
Conversation
|
@l-vo thanks for your contribution. Sadly I'm having some problems trying to understand the issue here. Are you saying that the current code won't work? That the current code is unnecessary? thanks! |
|
@javiereguiluz I think this code won't work in most cases. When the second argument of register isn't set, it's the compiler pass If I use Is it clearer ? |
|
@l-vo it's more clear now. Thanks! But before merging, let me ask our biggest expert in Dependency Injection to verify this change: @nicolas-grekas Thanks! |
|
I'm fine with this change, calling register can also be done in regular php definition of services, but nobody does that, so that the most common place to do this is in a compiler pass indeed. |
|
@l-vo thanks for fixing this error and for the detailed explanations. Also, congrats on your first Symfony Docs contribution! |
…to its class (l-vo) This PR was merged into the 3.4 branch. Discussion ---------- Remove example of register a service where its id match to its class `ResolveClassPass` which resolve service definitions where class match to the service id is one of the first compiler pass processed (priority 100 in beforeOptimizationPasses phase). When adding a custom compiler pass, it is by default added to the beforeOptimizationPasses but with the default priority of 0. So the `ResolveClassPass` has already been executed and our custom service definition class isn't resolved. Commits ------- 4905190 Remove example of register a service where its id match to its class
|
@javiereguiluz You're welcome ! Thanks :-)) |
ResolveClassPasswhich resolve service definitions where class match to the service id is one of the first compiler pass processed (priority 100 in beforeOptimizationPasses phase). When adding a custom compiler pass, it is by default added to the beforeOptimizationPasses but with the default priority of 0. So theResolveClassPasshas already been executed and our custom service definition class isn't resolved.