Minor reword

symfony · javiereguiluz · Jul 6, 2018 · Jul 5, 2018 · Jul 5, 2018 · Jul 5, 2018
commit 423bfae89b81cead319273ea1b9c1aef3430e127
diff --git a/reference/forms/twig_reference.rst b/reference/forms/twig_reference.rst
@@ -222,20 +222,18 @@ array).
 rootform
 ~~~~~~~~

-This test will check for sure if the current ``form`` does not have a parent form view.
-It would avoid collision and odd behavior when your form has defined a ``parent`` field.
+This test will check if the current ``form`` does not have a parent form view.

-Wrong example if your form has a field named ``parent``:
+.. code-block:: twig

-.. code-block:: jinja
+    {# DON'T DO THIS: this code will fail when the form doesn't have a parent
+       but it defines a normal form field called 'parent' #}

    {% if form.parent is null %}
        {{ form_errors(form) }}
    {% endif %}

-Correct example, this will check for the parent form view rather than its ``parent`` field:
-
-.. code-block:: jinja
+    {# DO THIS: this code will always work, regardless of the form field names #}

    {% if form is rootform %}
        {{ form_errors(form) }}
-Original file line number
+Diff line change
@@ -222,20 +222,18 @@ array).
     rootform
     ~~~~~~~~
-    This test will check for sure if the current ``form`` does not have a parent form view.
-    It would avoid collision and odd behavior when your form has defined a ``parent`` field.
+    This test will check if the current ``form`` does not have a parent form view.
-    Wrong example if your form has a field named ``parent``:
+    .. code-block:: twig
-    .. code-block:: jinja
+        {# DON'T DO THIS: this code will fail when the form doesn't have a parent
             Copy link

  
      
    
  

  
      

  
  Member


      

  Author


  

  
    
      

      
            yceruto
  

      

      

      


        Jul 5, 2018


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      I'd like to rephrase this sentence... since in no case this code will fail because the FormView has a public parent property. The problem appears when you have also defined a parent form field. The last one will have priority for Twig due the array access ability.
I'm not sure how to explain it in short though.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
            javiereguiluz reacted with thumbs up emoji
      
        
            
    All reactions
  


          
              
                👍
                  1 reaction
              
          
        
      
    

    



    
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
  Member


      

  Author


  

  
    
      

      
            yceruto
  

      

      

      


        Jul 5, 2018


      
  •

  
    
      
        
          edited
          
        
        
      
    
    
      
  
        
      Loading


  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  
    
  


    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      I mean... what you expect for form.parent could change depending on whether your form has or not a parent field. If no: you're checking the parent view, if yes: you're checking the parent field
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
            javiereguiluz reacted with thumbs up emoji
      
        
            
    All reactions
  


          
              
                👍
                  1 reaction
+           but it defines a normal form field called 'parent' #}
         {% if form.parent is null %}
             {{ form_errors(form) }}
         {% endif %}
-    Correct example, this will check for the parent form view rather than its ``parent`` field:
-    .. code-block:: jinja
+        {# DO THIS: this code will always work, regardless of the form field names #}
         {% if form is rootform %}
             {{ form_errors(form) }}
-          Expand Down