Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fd7b98f

Browse filesBrowse files
committed
Merge branch '4.4' into 5.0
* 4.4: Update definitions.rst [EventDispatcher] Fix position of `AddEventAliasesPass` [Contributing] Fix `trigger_error()` position in deprecated class
2 parents fac3a25 + 8e46ff7 commit fd7b98f
Copy full SHA for fd7b98f

File tree

3 files changed

+7
-3
lines changed
Filter options

3 files changed

+7
-3
lines changed

‎components/event_dispatcher.rst

Copy file name to clipboardExpand all lines: components/event_dispatcher.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,10 +235,10 @@ determine which instance is passed.
235235
use Symfony\Component\EventDispatcher\EventDispatcher;
236236

237237
$containerBuilder = new ContainerBuilder(new ParameterBag());
238-
$containerBuilder->addCompilerPass(new RegisterListenersPass(), PassConfig::TYPE_BEFORE_REMOVING);
239238
$containerBuilder->addCompilerPass(new AddEventAliasesPass([
240239
\AcmeFooActionEvent::class => 'acme.foo.action',
241240
]));
241+
$containerBuilder->addCompilerPass(new RegisterListenersPass(), PassConfig::TYPE_BEFORE_REMOVING)
242242

243243
$containerBuilder->register('event_dispatcher', EventDispatcher::class);
244244

‎contributing/code/conventions.rst

Copy file name to clipboardExpand all lines: contributing/code/conventions.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ ready to cope with them (by adding a custom error handler like the one used by
126126
the Web Debug Toolbar or by the PHPUnit bridge).
127127

128128
When deprecating a whole class the ``trigger_error()`` call should be placed
129-
between the namespace and the use declarations, like in this example from
129+
after the use declarations, like in this example from
130130
`ServiceRouterLoader`_::
131131

132132
namespace Symfony\Component\Routing\Loader\DependencyInjection;

‎service_container/definitions.rst

Copy file name to clipboardExpand all lines: service_container/definitions.rst
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,18 @@ fetched from the container::
8989

9090
// gets a specific argument
9191
$firstArgument = $definition->getArgument(0);
92+
93+
// adds a new argument with the name of the argument
94+
// $argumentName = the name of the argument in the constructor
95+
$argument = $definition->setArgument('$argumentName', $argumentValue);
9296

9397
// adds a new argument
9498
$definition->addArgument($argument);
9599

96100
// replaces argument on a specific index (0 = first argument)
97101
$definition->replaceArgument($index, $argument);
98102

99-
// replace all previously configured arguments with the passed array
103+
// replaces all previously configured arguments with the passed array
100104
$definition->setArguments($arguments);
101105

102106
.. caution::

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.