Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b24c8a4

Browse filesBrowse files
committed
minor #16870 [Console] Update questionhelper.rst (issamkhadiri1989)
This PR was submitted for the 6.0 branch but it was merged into the 4.4 branch instead. Discussion ---------- [Console] Update questionhelper.rst hello, when running the example as it is, a deprecation message is shown (i'm on PHP 8.1.6). the deprecation message says that ``trim(): Passing null to parameter #1 ($string) of type string is deprecated``. what if we add a normalizer that returns an empty string when the entered value is `null` otherwise returns the user's intial input. with this suggestion, the example works great <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- bf9e245 Update questionhelper.rst
2 parents f065b76 + bf9e245 commit b24c8a4
Copy full SHA for b24c8a4

File tree

Expand file treeCollapse file tree

1 file changed

+3
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-0
lines changed

‎components/console/helpers/questionhelper.rst

Copy file name to clipboardExpand all lines: components/console/helpers/questionhelper.rst
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,9 @@ You can also use a validator with a hidden question::
384384
$helper = $this->getHelper('question');
385385

386386
$question = new Question('Please enter your password');
387+
$question->setNormalizer(function ($value) {
388+
return null === $value ? '' : $value;
389+
});
387390
$question->setValidator(function ($value) {
388391
if (trim($value) == '') {
389392
throw new \Exception('The password cannot be empty');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.