Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit afadaab

Browse filesBrowse files
committed
Changed: The last parameters of a method may be removed
1 parent 44ecf16 commit afadaab
Copy full SHA for afadaab

File tree

Expand file treeCollapse file tree

1 file changed

+13
-11
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+13
-11
lines changed

‎contributing/code/bc.rst

Copy file name to clipboardExpand all lines: contributing/code/bc.rst
+13-11Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -83,12 +83,12 @@ Remove method No No
8383
Change name No No
8484
Add parameter without a default value No No
8585
Add parameter with a default value Yes [1]_ No
86-
Remove parameter No No
86+
Remove parameter Yes [2]_ Yes [2]_
8787
Add default value to a parameter Yes [1]_ No
8888
Remove default value of a parameter No No
8989
Add type hint to a parameter No No
9090
Remove type hint of a parameter Yes [1]_ No
91-
Change return type Yes [1]_ [2]_ No
91+
Change return type Yes [1]_ [3]_ No
9292
============================================== ============== ==============
9393

9494

@@ -185,7 +185,7 @@ Remove entirely No No
185185
Make final Yes [1]_ No
186186
Make abstract No No
187187
Change name or namespace No No
188-
Change parent class Yes [3]_ Yes [3]_
188+
Change parent class Yes [4]_ Yes [4]_
189189
Add interface Yes Yes
190190
Remove interface No No
191191
**Public Properties**
@@ -208,32 +208,34 @@ Change name No No
208208
Reduce visibility No No
209209
Add parameter without a default value No No
210210
Add parameter with a default value Yes [1]_ No
211-
Remove parameter No No
211+
Remove parameter Yes [2]_ Yes [2]_
212212
Add default value to a parameter Yes [1]_ No
213213
Remove default value of a parameter No No
214-
Add type hint to a parameter Yes [4]_ No
214+
Add type hint to a parameter Yes [5]_ No
215215
Remove type hint of a parameter Yes [1]_ No
216-
Change return type Yes [1]_ [2]_ No
216+
Change return type Yes [1]_ [3]_ No
217217
**Protected Methods**
218218
Add protected method Yes Yes
219219
Remove protected method Yes [1]_ No
220220
Change name No No
221221
Reduce visibility Yes [1]_ No
222222
Add parameter without a default value Yes [1]_ No
223223
Add parameter with a default value Yes [1]_ No
224-
Remove parameter Yes [1]_ No
224+
Remove parameter Yes [2]_ Yes [2]_
225225
Add default value to a parameter Yes [1]_ No
226226
Remove default value of a parameter Yes [1]_ No
227227
Add type hint to a parameter Yes [1]_ No
228228
Remove type hint of a parameter Yes [1]_ No
229-
Change return type Yes [1]_ [2]_ No
229+
Change return type Yes [1]_ [3]_ No
230230
================================================== ============== ==============
231231

232232

233233
.. [1] Should be avoided. When done, this change must be documented in the
234234
UGPRADE file.
235235
236-
.. [2] The return type may only be changed to compatible types. The following
236+
.. [2] Only the last parameter(s) of a method may be removed.
237+
238+
.. [3] The return type may only be changed to compatible types. The following
237239
type changes are allowed:
238240
239241
=================== ==================================================================
@@ -249,10 +251,10 @@ Change return type Yes [1]_ [2]_ No
249251
``Countable`` array
250252
=================== ==================================================================
251253
252-
.. [3] When changing the parent class, the original parent class must remain an
254+
.. [4] When changing the parent class, the original parent class must remain an
253255
ancestor of the class.
254256
255-
.. [4] A type hint may only be added if passing a value with a different type
257+
.. [5] A type hint may only be added if passing a value with a different type
256258
previously generated a fatal error.
257259
258260
.. _scalar type: http://php.net/manual/en/function.is-scalar.php

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.