Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9a74af4

Browse filesBrowse files
committed
Merge branch '2.7' into 2.8
* 2.7: [#9413] some minor tweaks Ask users to create two commits for reproducers
2 parents 3ea8315 + 475e668 commit 9a74af4
Copy full SHA for 9a74af4

File tree

Expand file treeCollapse file tree

2 files changed

+4
-2
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-2
lines changed

‎contributing/code/reproducer.rst

Copy file name to clipboardExpand all lines: contributing/code/reproducer.rst
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,10 @@ edition. To do so:
4242
``git clone git://github.com/YOUR-GITHUB-USERNAME/symfony-standard.git``
4343
#. Browse the project and create a new branch (e.g. ``issue_23567``,
4444
``reproduce_23657``, etc.)
45+
#. Add and commit the changes generated by Symfony.
4546
#. Now you must add the minimum amount of code to reproduce the bug. This is the
4647
trickiest part and it's explained a bit more later.
47-
#. Add, commit and push all your changes.
48+
#. Add, commit and push all your own changes.
4849
#. Add a comment in your original issue report to share the URL of your forked
4950
project (e.g. ``https://github.com/YOUR-GITHUB-USERNAME/symfony-standard/tree/issue_23567``)
5051
and, if necessary, explain the steps to reproduce (e.g. "browse this URL",

‎form/unit_testing.rst

Copy file name to clipboardExpand all lines: form/unit_testing.rst
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,9 @@ The simplest ``TypeTestCase`` implementation looks like the following::
6262
// submit the data to the form directly
6363
$form->submit($formData);
6464

65-
$objectToCompare = $form->getData();
6665
$this->assertTrue($form->isSynchronized());
66+
67+
// check that $objectToCompare was modified as expected when the form was submitted
6768
$this->assertEquals($object, $objectToCompare);
6869

6970
$view = $form->createView();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.