Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 83ef27d

Browse filesBrowse files
committed
minor #7985 Use of Setters and Getters (martin05)
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #7985). Discussion ---------- Use of Setters and Getters If I have already define getter for the $targetDir, I should use it. Commits ------- 789ed43 Use of Setters and Getters
2 parents cd8b892 + 789ed43 commit 83ef27d
Copy full SHA for 83ef27d

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed

‎controller/upload_file.rst

Copy file name to clipboardExpand all lines: controller/upload_file.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ logic to a separate service::
243243
{
244244
$fileName = md5(uniqid()).'.'.$file->guessExtension();
245245

246-
$file->move($this->targetDir, $fileName);
246+
$file->move($this->getTargetDir(), $fileName);
247247

248248
return $fileName;
249249
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.