Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 535d3a9

Browse filesBrowse files
jmschericardodevries
jmsche
and
ricardodevries
authored
Apply suggestions/improvements from code review.
Co-Authored-By: ricknox <ricardo@43.nl>
1 parent a4440f9 commit 535d3a9
Copy full SHA for 535d3a9

File tree

Expand file treeCollapse file tree

8 files changed

+9
-9
lines changed
Filter options
Expand file treeCollapse file tree

8 files changed

+9
-9
lines changed

‎best_practices/templates.rst

Copy file name to clipboardExpand all lines: best_practices/templates.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class in the constructor of the Twig extension::
126126
new TwigFilter(
127127
'md2html',
128128
[$this, 'markdownToHtml'],
129-
['is_safe' => ['html'], 'pre_escape' => 'html')
129+
['is_safe' => ['html'], 'pre_escape' => 'html']
130130
),
131131
);
132132
}

‎components/cache/cache_invalidation.rst

Copy file name to clipboardExpand all lines: components/cache/cache_invalidation.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ cache items, as returned by cache adapters::
3636
// ...
3737
// add one or more tags
3838
$item->tag('tag_1');
39-
$item->tag(['tag_2', 'tag_3'[);
39+
$item->tag(['tag_2', 'tag_3']);
4040
$cache->save($item);
4141

4242
If ``$cache`` implements :class:`Symfony\\Component\\Cache\\Adapter\\TagAwareAdapterInterface`,

‎components/ldap.rst

Copy file name to clipboardExpand all lines: components/ldap.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ Or you could directly specify a connection string::
6565

6666
use Symfony\Component\Ldap\Ldap;
6767

68-
$ldap = Ldap::create('ext_ldap', ['connection_string' => 'ldaps://my-server:636'));
68+
$ldap = Ldap::create('ext_ldap', ['connection_string' => 'ldaps://my-server:636']);
6969

7070
The :method:`Symfony\\Component\\Ldap\\Ldap::bind` method
7171
authenticates a previously configured connection using both the

‎components/property_access.rst

Copy file name to clipboardExpand all lines: components/property_access.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ The ``getValue()`` method can also use the magic ``__get()`` method::
178178
{
179179
private $children = [
180180
'Wouter' => [...],
181-
);
181+
];
182182

183183
public function __get($id)
184184
{

‎components/translation/usage.rst

Copy file name to clipboardExpand all lines: components/translation/usage.rst
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ recommended format. These files are parsed by one of the loader classes.
198198
'user' => [
199199
'login' => 'Login',
200200
],
201-
);
201+
];
202202
203203
The multiple levels are flattened into single id/translation pairs by
204204
adding a dot (``.``) between every level, therefore the above examples are
@@ -431,7 +431,7 @@ The ``$messages`` variable will have the following structure::
431431
'Value should not be empty' => 'Valeur ne doit pas être vide',
432432
'Value is too long' => 'Valeur est trop long',
433433
],
434-
);
434+
];
435435

436436
Adding Notes to Translation Contents
437437
------------------------------------

‎contributing/community/review-comments.rst

Copy file name to clipboardExpand all lines: contributing/community/review-comments.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ If a piece of code is in fact wrong, explain why:
113113

114114
* I profiled this change and it hurts performance significantly (if you don't profile, it's an opinion, so we can ignore)
115115

116-
* Code doesn't match Symfony's CS rules (e.g. use ``[]`` instead of ``[]``)
116+
* Code doesn't match Symfony's CS rules (e.g. use ``[]`` instead of ``array()``)
117117

118118
* We only provide integration with very popular projects (e.g. we integrate Bootstrap but not your own CSS framework)
119119

‎create_framework/http_kernel_controller_resolver.rst

Copy file name to clipboardExpand all lines: create_framework/http_kernel_controller_resolver.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ two colons and a method name as a valid callback, like 'class::method'::
7575
$routes->add('leap_year', new Routing\Route('/is_leap_year/{year}', [
7676
'year' => null,
7777
'_controller' => 'LeapYearController::indexAction',
78-
])));
78+
]));
7979

8080
To make this code work, modify the framework code to use the controller
8181
resolver from HttpKernel::

‎doctrine/mongodb_session_storage.rst

Copy file name to clipboardExpand all lines: doctrine/mongodb_session_storage.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ need to change/add some parameters in the main configuration file:
9494
['mongodb://%mongodb_username%:%mongodb_password%@%mongodb_host%:27017'],
9595
// if not using a username and password
9696
['mongodb://%mongodb_host%:27017'],
97-
));
97+
]);
9898
9999
$container->register('session.handler.mongo', MongoDbSessionHandler::class)
100100
->setArguments([

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.