Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 13753df

Browse filesBrowse files
brooksvbbrooksvb
authored
Clearer wording of allow_delete template behavior
``` The allow_delete option has one consequence: if an item of a collection isn't sent on submission, the related data is removed from the collection on the server. The solution is to remove the form element from the DOM. ``` *The solution is to remove the form element from the DOM* is a confusing sentence. Saying "the solution" implies that there is some sort of problem with enabling `allow_delete` that needs to be solved. I found it very confusing what the problem was, and reread the section multiple times to figure out what it was supposed to be. I finally understood that what it's _trying_ to say is that if you want the *intended* behavior to work, (not problematic, because you are enabling the behavior intentionally), you have to remove the collection item from the submitted data. In terms of submitting the form through a webpage, that means removing the DOM element. Also removed `has one consequence` from the first sentence of the paragraph, because calling it a consequence, again, implies that it's a behavior you don't really want, despite the fact you're enabling it intentionally. Overall, I think these small changes would prevent some unnecessary confusion like what I experienced.
1 parent f5480e5 commit 13753df
Copy full SHA for 13753df

File tree

Expand file treeCollapse file tree

1 file changed

+4
-2
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-2
lines changed

‎form/form_collections.rst

Copy file name to clipboardExpand all lines: form/form_collections.rst
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -625,9 +625,11 @@ Now, you need to put some code into the ``removeTag()`` method of ``Task``::
625625
Template Modifications
626626
~~~~~~~~~~~~~~~~~~~~~~
627627

628-
The ``allow_delete`` option has one consequence: if an item of a collection
628+
The ``allow_delete`` option means that if an item of a collection
629629
isn't sent on submission, the related data is removed from the collection
630-
on the server. The solution is to remove the form element from the DOM.
630+
on the server. In order for this to work in an HTML form, you must remove
631+
the DOM element for the collection item to be removed, before submitting
632+
the form.
631633

632634
First, add a "delete this tag" link to each tag form:
633635

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.