Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 03fa56d

Browse filesBrowse files
committed
Merge branch '4.2'
* 4.2: removed obsolete versionadded-directive Minor "Review comments" tweaks use correct code-block removed versionadded, fixed count and note which behaves like versionadded Persisting : forget a \"use\" statement ?
2 parents 7c9f631 + b9ab0b5 commit 03fa56d
Copy full SHA for 03fa56d

File tree

4 files changed

+21
-19
lines changed
Filter options

4 files changed

+21
-19
lines changed

‎contributing/community/review-comments.rst

Copy file name to clipboardExpand all lines: contributing/community/review-comments.rst
+13-13Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -91,34 +91,34 @@ Don't use hyperbole ("always", "never", "endlessly", "nothing", "worst", "horrib
9191
**Don't:** *"I don't like how you wrote this code"* - there is no clear explanation why you
9292
don't like how it's written.
9393

94-
**Better:** *"I find it hard to read this code as there many nested if statements, can you make it more
95-
readable? By encapsulating some of it's details or maybe adding some comments to explain the overall logic."* -
94+
**Better:** *"I find it hard to read this code as there is many nested if statements, can you make it more
95+
readable? By encapsulating some of its details or maybe adding some comments to explain the overall logic."* -
9696
You explain why you find the code hard to read *and* give some suggestions for improvement.
9797

9898
If a piece of code is in fact wrong, explain why:
9999

100-
* ``This code doesn't comply with Symfony's CS rules. Please see [...] for details``.
100+
* "This code doesn't comply with Symfony's CS rules. Please see [...] for details."
101101

102-
* ``Symfony 3 still uses PHP 5 and doesn't allow the usage scalar type-hints.``.
102+
* "Symfony 3 still uses PHP 5 and doesn't allow the usage scalar type-hints."
103103

104-
* ``I think the code is less readable now`` - careful here, be sure explain why you think
104+
* "I think the code is less readable now." - careful here, be sure explain why you think
105105
the code is less readable, and maybe give some suggestions?
106106

107107
**Examples of valid reasons to reject:**
108108

109-
* We tried that in the past (link to the relevant PR) but we needed to revert it for XXX reason.
109+
* "We tried that in the past (link to the relevant PR) but we needed to revert it for XXX reason."
110110

111-
* That change would introduce too many merge conflicts when merging up Symfony branches.
112-
In the past we've always rejected changes like this.
111+
* "That change would introduce too many merge conflicts when merging up Symfony branches.
112+
In the past we've always rejected changes like this."
113113

114-
* I profiled this change and it hurts performance significantly (if you don't profile, it's an opinion, so we can ignore)
114+
* "I profiled this change and it hurts performance significantly" - if you don't profile, it's an opinion, so we can ignore
115115

116-
* Code doesn't match Symfony's CS rules (e.g. use ``[]`` instead of ``array()``)
116+
* "Code doesn't match Symfony's CS rules (e.g. use ``[]`` instead of ``array()``)"
117117

118-
* We only provide integration with very popular projects (e.g. we integrate Bootstrap but not your own CSS framework)
118+
* "We only provide integration with very popular projects (e.g. we integrate Bootstrap but not your own CSS framework)"
119119

120-
* This would require adding lots of code and making lots of changes for a feature that doesn't look so important.
121-
That could hurt maintaining in the future.
120+
* "This would require adding lots of code and making lots of changes for a feature that doesn't look so important.
121+
That could hurt maintaining in the future."
122122

123123
Asking for Changes
124124
------------------

‎controller/argument_value_resolver.rst

Copy file name to clipboardExpand all lines: controller/argument_value_resolver.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ functionality.
1515
Functionality Shipped with the HttpKernel
1616
-----------------------------------------
1717

18-
Symfony ships with five value resolvers in the HttpKernel component:
18+
Symfony ships with the following value resolvers in the HttpKernel component:
1919

2020
:class:`Symfony\\Component\\HttpKernel\\Controller\\ArgumentResolver\\RequestAttributeValueResolver`
2121
Attempts to find a request attribute that matches the name of the argument.

‎doctrine.rst

Copy file name to clipboardExpand all lines: doctrine.rst
+6-4Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,8 @@ and save it!
340340
namespace App\Controller;
341341
342342
// ...
343+
use Symfony\Component\HttpFoundation\Response;
344+
343345
use App\Entity\Product;
344346
345347
class ProductController extends AbstractController
@@ -386,17 +388,17 @@ Take a look at the previous example in more detail:
386388

387389
.. _doctrine-entity-manager:
388390

389-
* **line 16** The ``$this->getDoctrine()->getManager()`` method gets Doctrine's
391+
* **line 18** The ``$this->getDoctrine()->getManager()`` method gets Doctrine's
390392
*entity manager* object, which is the most important object in Doctrine. It's
391393
responsible for saving objects to, and fetching objects from, the database.
392394

393-
* **lines 18-21** In this section, you instantiate and work with the ``$product``
395+
* **lines 20-23** In this section, you instantiate and work with the ``$product``
394396
object like any other normal PHP object.
395397

396-
* **line 24** The ``persist($product)`` call tells Doctrine to "manage" the
398+
* **line 26** The ``persist($product)`` call tells Doctrine to "manage" the
397399
``$product`` object. This does **not** cause a query to be made to the database.
398400

399-
* **line 27** When the ``flush()`` method is called, Doctrine looks through
401+
* **line 29** When the ``flush()`` method is called, Doctrine looks through
400402
all of the objects that it's managing to see if they need to be persisted
401403
to the database. In this example, the ``$product`` object's data doesn't
402404
exist in the database, so the entity manager executes an ``INSERT`` query,

‎workflow/usage.rst

Copy file name to clipboardExpand all lines: workflow/usage.rst
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ of domain logic in your templates:
438438

439439
The following example shows these functions in action:
440440

441-
.. code-block:: twig
441+
.. code-block:: html+twig
442442

443443
<h3>Actions</h3>
444444
{% if workflow_can(post, 'publish') %}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.