Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Form] Added a configuration that allow form extra data #9377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

goetas
Copy link
Contributor

@goetas goetas commented Oct 25, 2013

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #7209
License MIT

I can not understand how 1099858 can solve #7209 or #7229, so i created this PR.
I can not also understand why #7209 can be considered as duplicate of #1341 (1099858).

The commit 1099858 will solve problem if some fields is missing, but says nothing about extra fields.

$context = $this->getMockExecutionContext();

$form = $this->getBuilder('parent', null, array('allow_extra_fields'=>true))
->setCompound(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be indented?

@@ -615,6 +615,25 @@ public function testViolationIfExtraData()
$this->validator->validate($form, new Form());
}

public function testViolationIfExtraDataAllowed()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testNoViolation...

@webmozart
Copy link
Contributor

Looks good! Symfony 2.4 is already feature-frozen, postponed to 2.5.

@goetas
Copy link
Contributor Author

goetas commented Nov 11, 2013

Thanks!

@Taluu
Copy link
Contributor

Taluu commented Jan 21, 2014

Is there any news on this PR (if it could be merged or whatever for 2.5 as @bschussek mentionned it) ?

@goetas
Copy link
Contributor Author

goetas commented Jan 21, 2014

ping @bschussek

@vendethiel
Copy link

👍

@Nemesisprime
Copy link

Also curious about this!

@webmozart
Copy link
Contributor

Just realized that this is a duplicate of #8133.

@webmozart webmozart closed this Apr 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.