-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] Added a configuration that allow form extra data #9377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
$context = $this->getMockExecutionContext(); | ||
|
||
$form = $this->getBuilder('parent', null, array('allow_extra_fields'=>true)) | ||
->setCompound(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be indented?
@@ -615,6 +615,25 @@ public function testViolationIfExtraData() | ||
$this->validator->validate($form, new Form()); | ||
} | ||
|
||
public function testViolationIfExtraDataAllowed() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testNoViolation...
Looks good! Symfony 2.4 is already feature-frozen, postponed to 2.5. |
Thanks! |
Is there any news on this PR (if it could be merged or whatever for 2.5 as @bschussek mentionned it) ? |
ping @bschussek |
👍 |
Also curious about this! |
Just realized that this is a duplicate of #8133. |
I can not understand how 1099858 can solve #7209 or #7229, so i created this PR.
I can not also understand why #7209 can be considered as duplicate of #1341 (1099858).
The commit 1099858 will solve problem if some fields is missing, but says nothing about extra fields.