Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[2.2] sub-requests are now created with the same class as their parent #7390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2013
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
replaced new occurences of 'Request::create()' with '::create()'
  • Loading branch information
jfsimon committed Mar 15, 2013
commit 53cf12b544abde58f85126e7bc72205ca6b42f49
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ protected function createSubRequest($uri, Request $request)
// the sub-request is internal
$server['REMOTE_ADDR'] = '127.0.0.1';

$subRequest = Request::create($uri, 'get', array(), $cookies, array(), $server);
$subRequest = $request::create($uri, 'get', array(), $cookies, array(), $server);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to invoke static methods on objects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's weird, but it makes sense.
See comments in #7381.

if ($session = $request->getSession()) {
$subRequest->setSession($session);
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.