Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 13, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #62046
License MIT

Document a breaking change introduced in fbf3814

@chalasr
Copy link
Member

chalasr commented Oct 13, 2025

I understand the intent but our BC promise doesn't cover that case, I fear doing this might send the wrong signal

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 13, 2025

While at it: what would it take to preserve the previous behavior? Would there really be a new-BC concern?

@stof
Copy link
Member

stof commented Oct 13, 2025

The fact that our BC promise does not cover that change is what allows us to do it. But it might make sense to document this change (probably not as a BC Break IMO), to make people reading the changelog aware of it.

UPGRADE-6.4.md Outdated Show resolved Hide resolved
@derrabus
Copy link
Member

While at it: what would it take to preserve the previous behavior? Would there really be a new-BC concern?

Let's say someone overrides both renderView() and render() to hook into the rendering and execute some additional logic. If we restored the previous behavior and have render() call renderView() again, that hook logic is called twice. So for someone who relied on the post-6.4 behavior, restoring the pre-6.4 behavior is a BC break. I wouldn't do it.

UPGRADE-6.4.md Outdated Show resolved Hide resolved
@GromNaN
Copy link
Member Author

GromNaN commented Oct 13, 2025

I updated the message to remove the "BC break" mention.

@nicolas-grekas
Copy link
Member

Thank you @GromNaN.

@nicolas-grekas nicolas-grekas merged commit 590eeec into symfony:6.4 Oct 13, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.