Fix generating logout link with stateless csrf #62037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for bug fixes". Cheers! Carsonbot |
src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Oct 12, 2025
1328ea3 to
9e5e32b
Compare
|
Thank you @pierredup. |
stof
reviewed
Oct 13, 2025
|
|
||
| if (null !== $this->csrfTokenManager) { | ||
| $csrfToken = ParameterBagUtils::getRequestParameterValue($request, $this->options['csrf_parameter']); | ||
| $csrfToken = ParameterBagUtils::getRequestParameterValue($request, $this->options['csrf_parameter'], $request->request->all()); |
There was a problem hiding this comment.
$request->request should be used only for POST requests, not for GET requests
There was a problem hiding this comment.
IMO we need to revert the whole PR as is (see #62086) and work on fixing the root issue instead (a URL with an invalid CSRF token being generated).
There was a problem hiding this comment.
$request->request->all() is going to be empty so that we'll properly fallback to the query-string on GET requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
logout_path(orlogout_url) twig function with stateless csrf, the generator creates a link with an invalid CSRF token parameter (/logout?_csrf_token=csrf-token), which then causes an error during logout (Invalid CSRF token), since the LogoutListener reads the token from the query parameter first.Reproducer: