Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

VincentLanglet
Copy link
Contributor

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #...
License MIT

Since getRetryDelay was added, the RecoverableMessageHandlingException is useful to override the defaut delay of the retry strategy (for instance if we get rate limited by some thing and would like to retry after some delay). BUT this imply the message will be retried again and again if we keep getting such error.

#49063 asked RecoverableMessageHandlingException to respect the retryStrategy and #50655 revert it because if RecoverableMessageHandlingException respect the retry strategy it has no use. Now I think this feature would be useful, as an option:

  • Use forceRetry to always retry (default behavior)
  • Use forceRetry=false to retry if the retry strategy allows it, and if so override the delay with retryDelay.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changelog and upgrade files should mention the new method

@VincentLanglet
Copy link
Contributor Author

Thanks for the review @nicolas-grekas ; I updated the PR.

Failure seems unrelated since they are redis-related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.