Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Workflow] Extract code from the data collector to a dedicated class #61914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 7.4
Choose a base branch
Loading
from
Open

[Workflow] Extract code from the data collector to a dedicated class #61914

wants to merge 1 commit into from
+238 −105

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Oct 1, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? yes
Issues
License MIT

I prepare battlefield for #60208

@carsonbot carsonbot added this to the 7.4 milestone Oct 1, 2025
@lyrixx lyrixx force-pushed the workflow-dump-with-guard branch from b1a6594 to b90fee6 Compare October 1, 2025 16:20
fabpot
fabpot requested changes Oct 2, 2025
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer constraints should probably be updated to fix the tests.

@lyrixx lyrixx force-pushed the workflow-dump-with-guard branch 2 times, most recently from d5ec340 to 07dd672 Compare October 2, 2025 12:59
@lyrixx lyrixx changed the title [Workflow] Extract code from the data collector to a compiler pass [Workflow] Extract code from the data collector to a dedicated class Oct 2, 2025
@lyrixx
Copy link
Member Author

lyrixx commented Oct 2, 2025

I changed the implementation. It's not a compiler pass anymore, it's a dedicated class!

@lyrixx lyrixx force-pushed the workflow-dump-with-guard branch from 07dd672 to dacf8c1 Compare October 2, 2025 13:00
stof
stof reviewed Oct 2, 2025
View reviewed changes
src/Symfony/Component/Workflow/Debug/ListenerExtractor.php Show resolved Hide resolved
@lyrixx lyrixx force-pushed the workflow-dump-with-guard branch from dacf8c1 to 5d69688 Compare October 2, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot requested changes

Assignees

No one assigned

Labels

Deprecation Status: Needs Work Workflow

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

4 participants

@lyrixx @fabpot @stof @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.