[SecurityBundle] Use Firewall as default tab in the WebProfiler when no token is set #61899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But the security panel default tab is “Token” so it makes sense greying the menu link if there is none. Else that means you click an “active” link and end up on an empty state: 
I think this PR would be better by making the “Firewall” tab the default one, but that is yet another change (and not a bugfix). |
7e93bae to
07df134
Compare
|
I thin the token tab is more useful as default tab when it is enabled, as the firewall tab describes the config of the project, not per-request information. |
07df134 to
ef92eb5
Compare
ef92eb5 to
ed0915a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels weird that the "Security" item of the profiler sidebar is shown as disabled and placed in the "not active" components sections even though the request goes through several Security listeners:
With this change we disable it only when security is not enabled on the main firewall and we use the Firewall tab as the Security default tab when the token is not set to maintain consistency as pointed out by @MatTheCat :
