[Cache] Redis Sentinel - Allow having 2 different auth in config for master & sentinel #61783
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…master & sentinel Many time, same auth (like password) is set on both Redis master and Sentinel, but you may want to not use the same auth for both of them. Currently, using DNS, you can only set one and only one auth for both. This PR allow to set a different auth for sentinel while keeping backward compatibility for previous DSN config.
4b0c391 to
dbdeb0b
Compare
|
As it is currently, the PR is a new feature of course. Looking closer at sentinels, it looks like we should support having a different auth setting per-sentinel. This concern should also apply to clusters I guess. About the Up to digg these ideas? |
|
Yes @nicolas-grekas , I can digg them 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many time, same auth (like password) is set on both Redis master and Sentinel, but you may want to not use the same auth for both of them.
Currently, using DNS, you can only set one and only one auth for both.
This PR allow to set a different auth for sentinel while keeping backward compatibility for previous DSN config.
Problematical usage
Add
authoption will override the passwordmasterPassword.Fixed usage
redis_sentinel_authoption will be prioritized overauthoption. That way, after update, an existing DSN will still work as it was before.