[Serializer] Fix unknown type in denormalization errors when union type used in constructor #61746
+89
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
…pe used in constructor
0cd2b6e to
eb8f941
Compare
|
Thank you @d-mitrofanov-v. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes getting "unknown" in
expectedTypesofNotNormalizableValueExceptionif constructor properties have union types and if this property is absent from json. This also fixes getting error "This value should be of type unknown" when building text forPartialDenormalizationExceptioninRequestPayloadValueResolver. The resulting string will be "This value should be of type int|float".The only problem that i see is that
ReflectionUnionType::getTypes()returns types in its own order which might not be the same as the order in constructor. For example, even if we havefloat|intin constructor,ReflectionUnionType::getTypes()will return types inint, floatorder. But it seems that getting types in a different order is still better then getting "unknown"