[Console] Fix handling of \E in Bash completion
#61724
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @HypeMC, The proposed fix may cause other issues. What if we completely remove this line and rely on the loop instead? |
|
@Spomky Hi.
Do you have any examples you could share?
Have you experienced problems with paths on any other OS?
I haven't tested it, but that might reintroduce the original issue #43665 tried to fix. |
Spomky
approved these changes
Sep 12, 2025
|
Thank you @HypeMC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #43665
The problem with
$(printf -- '%b' "$w")is that it also interprets\Eas an escape sequence.For example, in
bin/console debug:form 'Symfony\Component\Form\Extension\Core\Type\EmailType'the
\Ein the class name is replaced with the ASCII escape character:This PR switches to simply replacing double backslashes with a single one instead of using
printf -- '%b'.