[Console] Don’t automatically append EOT to multiline test inputs #61690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Sep 8, 2025
src/Symfony/Component/Console/Tests/Tester/CommandTesterTest.php
Outdated
Show resolved
Hide resolved
613916b to
bede3de
Compare
535e8ad to
938fabb
Compare
|
Thank you @MatTheCat. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 8, 2025
…th an EOT (MatTheCat) This PR was merged into the 6.4 branch. Discussion ---------- [Console] Don’t append a new line to test inputs ending with an EOT | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT #61501 wrote a new line before multiline test inputs’ EOT character, and #61690 wrote it after… so the next input would always be empty. This PR doesn’t write a new line if a test input ends with `\x4` so that the stream matches the inputs. Commits ------- 74ae155 [Console] Don’t append a new line to test inputs ending with an EOT
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 9, 2025
…wer (MatTheCat) This PR was submitted for the 7.3 branch but it was merged into the 6.4 branch instead. Discussion ---------- [Console] Mention how to test a multiline question’s answer symfony/symfony#61690 follow-up Commits ------- 4545c5a [Console] Mention how to test a multiline question’s answer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61501 assumed multiline inputs were answers to multiline questions and suffixed them with an EOT character to mark their end.
But if you’re directly reading stdin, you can have line breaks without the need for an EOT: #61501 (comment)
Since the
TesterTraitdoesn’t know the inputs’ context, this PR reverts this behavior. Multiline questions will still be able to be tested by manually suffixing the answer with an EOT (x04) like in the added test.Documentation PR: symfony/symfony-docs#21357