Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

KevinVanSonsbeek
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #61581
License MIT

Rewritten the places beforeNormalization callback, to normalize the defined places one by one. Rather than asserting behavior based on only the first item in the passed array.

This way it is possible to combine places in both the "simplistic" and non simplistic format for 1 workflow.

@carsonbot carsonbot added this to the 7.4 milestone Sep 2, 2025
@carsonbot carsonbot changed the title Bugfix/61581 workflow exceptions on combined place definitions Bugfix/61581 workflow exceptions on combined place definitions Sep 2, 2025
@KevinVanSonsbeek KevinVanSonsbeek changed the base branch from 7.4 to 6.4 September 2, 2025 20:07
@KevinVanSonsbeek KevinVanSonsbeek changed the title Bugfix/61581 workflow exceptions on combined place definitions [FrameworkBundle] [Config] Normalize workflow places separately Sep 2, 2025
@KevinVanSonsbeek KevinVanSonsbeek force-pushed the bugfix/61581-workflow-exceptions-on-combined-place-definitions branch 3 times, most recently from 4009e69 to 5121921 Compare September 2, 2025 20:18
@KevinVanSonsbeek
Copy link
Contributor Author

It seems both the reviewer and milestone are not removed by @carsonbot after the target branch is changed.

@nicolas-grekas nicolas-grekas modified the milestones: 7.4, 6.4 Sep 3, 2025
@symfony symfony deleted a comment from carsonbot Sep 8, 2025
@carsonbot carsonbot changed the title [FrameworkBundle] [Config] Normalize workflow places separately [FrameworkBundle] Normalize workflow places separately Sep 8, 2025
@nicolas-grekas nicolas-grekas force-pushed the bugfix/61581-workflow-exceptions-on-combined-place-definitions branch from 5121921 to 032000e Compare September 8, 2025 13:47
@nicolas-grekas nicolas-grekas force-pushed the bugfix/61581-workflow-exceptions-on-combined-place-definitions branch from 032000e to eddc6a6 Compare September 8, 2025 13:50
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've simplified the code and removed strict types, which we don't use on this repo.

@nicolas-grekas
Copy link
Member

Thank you @KevinVanSonsbeek.

@nicolas-grekas nicolas-grekas merged commit f1fb422 into symfony:6.4 Sep 8, 2025
8 of 10 checks passed
nicolas-grekas added a commit that referenced this pull request Sep 16, 2025
…sitions' from/to configs (nicolas-grekas)

This PR was merged into the 6.4 branch.

Discussion
----------

[FrameworkBundle] Perform-no-deep-merging on workflow transitions' from/to configs

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Similar to #61596 but for transitions.

Also replaces #57873 per `@stof`'s comment at #57873 (comment)

Commits
-------

66fff01 [FrameworkBundle] Perform-no-deep-merging on workflow transitions' from/to configs
This was referenced Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow config exception on mixed place definitions

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.