[JsonPath] Make the component RFC compliant #61132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
stof
reviewed
Jul 16, 2025
d1364da to
99ff096
Compare
stloyd
reviewed
Jul 17, 2025
54281cb to
ac36023
Compare
50fc0b2 to
9111782
Compare
9111782 to
4a68767
Compare
56993dc to
cfe7dc3
Compare
cfe7dc3 to
25bedc6
Compare
stof
reviewed
Aug 25, 2025
25bedc6 to
a7a9f5b
Compare
|
Both comments addressed @stof. Thanks! |
src/Symfony/Component/JsonPath/Tests/JsonPathComplianceTestSuiteTest.php
Show resolved
Hide resolved
| } | ||
| } | ||
| } else { | ||
| foreach ($left as $key => $value) { |
There was a problem hiding this comment.
this foreach means the order of the keys don't matter - is this covered by the test suite?
There was a problem hiding this comment.
Actually we can keep only this loop, the comparison is order independent (see https://datatracker.ietf.org/doc/rfc9535/ section 2.5.2.2)
|
Comments addressed in b2e7b34, thanks for the extensive review |
21352ba to
0b5baee
Compare
nicolas-grekas
approved these changes
Sep 9, 2025
0b5baee to
0729c54
Compare
|
Thank you @alexandre-daubois. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the JsonPath component RFC compliant by removing all skipped tests of the compliance test suite.