[HtmlSanitizer] Add support for securing target="_blank" links #60539
+86
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `ensureSafeBlankTarget` to automatically add `rel="noopener noreferrer"` to `<a>` elements with `target="_blank"`, mitigating reverse tabnabbing risks. The `allowUnsafeBlankTargets` method allows opting out of this behavior if needed. Included tests validate the new functionality.
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.4". Cheers! Carsonbot |
|
/cc @tgalopin can you please check this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
ensureSafeBlankTargetto automatically addrel="noopener noreferrer"to<a>elements withtarget="_blank", mitigating reverse tabnabbing risks.The
allowUnsafeBlankTargetsmethod allows opting out of this behavior if needed.ℹ️ Info: Modern browsers already consider
noopenerevent if missing. However the presence of therelattribute is still considered as [a good practice](https://cheatsheetseries.owasp.org/cheatsheets/HTML5_Security_Cheat_Sheet.html#tabnabbing) by the OWASP.
⚠ Warning: I modified
Node::setAttributeto allow overwriting existing attributes. I might have missed the reason for the commentAlways use only the first declaration (ease sanitization).⚠ Warning: The logic is implemented in
DomVisitor. It works, however I am wondering if an abstraction is needed.