-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Remove translations for slug validation error #60486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
I was wondering if removing these translations could be seen as a BC break because technically they have already been part of stable releases and theoretically could have been used by developers in their applications. Are we fine with that? |
It cannot be a BC break as 7.3 stable has not been released yet. |
What I mean is that the translations have been part of the 6.4.18+/7.1.11+/7.2.3+ releases and one could just use them with their own constraints or passing them directly to the translator without needing the actual |
Sure, I understand that. Still, I don't think this should be considered as a BC break as we're adding translations on 6.4 just to ease our work. |
Maybe we should add this to our BC promise definition? |
Works for me, I agree with Oskar though that it might make sense to add this to our BC promise. |
I created an issue |
Related to #60475