Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove translations for slug validation error #60486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented May 20, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Related to #60475

@carsonbot carsonbot added this to the 7.3 milestone May 20, 2025
@carsonbot

This comment was marked as resolved.

@alexandre-daubois alexandre-daubois modified the milestones: 7.3, 6.4 May 20, 2025
@alexandre-daubois alexandre-daubois changed the base branch from 7.3 to 6.4 May 20, 2025 06:49
@xabbuh
Copy link
Member

xabbuh commented May 20, 2025

I was wondering if removing these translations could be seen as a BC break because technically they have already been part of stable releases and theoretically could have been used by developers in their applications. Are we fine with that?

@fabpot
Copy link
Member Author

fabpot commented May 20, 2025

I was wondering if removing these translations could be seen as a BC break because technically they have already been part of stable releases and theoretically could have been used by developers in their applications. Are we fine with that?

It cannot be a BC break as 7.3 stable has not been released yet.

@fabpot fabpot merged commit 0088138 into symfony:6.4 May 20, 2025
11 checks passed
@fabpot fabpot deleted the slug-translation-removal branch May 20, 2025 06:54
@xabbuh
Copy link
Member

xabbuh commented May 20, 2025

It cannot be a BC break as 7.3 stable has not been released yet.

What I mean is that the translations have been part of the 6.4.18+/7.1.11+/7.2.3+ releases and one could just use them with their own constraints or passing them directly to the translator without needing the actual Slug constraint. 🤷‍♂️

@fabpot
Copy link
Member Author

fabpot commented May 20, 2025

It cannot be a BC break as 7.3 stable has not been released yet.

What I mean is that the translations have been part of the 6.4.18+/7.1.11+/7.2.3+ releases and one could just use them with their own constraints or passing them directly to the translator without needing the actual Slug constraint. 🤷‍♂️

Sure, I understand that. Still, I don't think this should be considered as a BC break as we're adding translations on 6.4 just to ease our work.

@OskarStark
Copy link
Contributor

Maybe we should add this to our BC promise definition?

@xabbuh
Copy link
Member

xabbuh commented May 20, 2025

Sure, I understand that. Still, I don't think this should be considered as a BC break as we're adding translations on 6.4 just to ease our work.

Works for me, I agree with Oskar though that it might make sense to add this to our BC promise.

@OskarStark
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.