Update src/Symfony/Component/ObjectMapper/Transform/MapCollection.php

Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
symfony · soyuka · May 17, 2025 · May 19, 2025 · May 20, 2025 · May 20, 2025
commit 6420b1b79a96dee19537560b1f4261fca46899ec
diff --git a/src/Symfony/Component/ObjectMapper/Transform/MapCollection.php b/src/Symfony/Component/ObjectMapper/Transform/MapCollection.php
@@ -23,7 +23,7 @@
 */
 class MapCollection implements TransformCallableInterface
 {
-    public function __construct(private ?ObjectMapperInterface $objectMapper = new ObjectMapper())
+    public function __construct(private ObjectMapperInterface $objectMapper = new ObjectMapper())
    {
    }

@@ -34,7 +34,7 @@
        }

        foreach ($value as &$v) {
            $v = $this->objectMapper->map($v);
        }

        return $value;
-Original file line number
+Diff line change
@@ -23,7 +23,7 @@
      */
     class MapCollection implements TransformCallableInterface
     {
-        public function __construct(private ?ObjectMapperInterface $objectMapper = new ObjectMapper())
+        public function __construct(private ObjectMapperInterface $objectMapper = new ObjectMapper())
         {
         }
@@ -34,7 +34,7 @@
             }
             foreach ($value as &$v) {
             Copy link

  
      
    
  

  
      

  
    Contributor


      

  Author


  

  
    
      

      
            soyuka
  

      

      

      


        May 20, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      I think it'd be best to create a new array this is probably why psalm is not happy :P
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



  
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
    Contributor


      

  

  
    
      

      
            mtarld
  

      

      

      


        May 21, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Indeed. Plus, if the iterator is not rewindable, the actual implementation can cause troubles.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
            soyuka reacted with thumbs up emoji
      
        
            
    All reactions
  


          
              
                👍
                  1 reaction
                 $v = $this->objectMapper->map($v);
     Check failure
        on line 37
        in src/Symfony/Component/ObjectMapper/Transform/MapCollection.php
  



  
      
View workflow job for this annotation

  

  
    
    GitHub Actions / Psalm
  

  
    
      NoValue
    
  

  
    src/Symfony/Component/ObjectMapper/Transform/MapCollection.php:37:13: NoValue: All possible types for this assignment were invalidated - This may be dead code (see https://psalm.dev/179)
  




        
  
  
      
  
  
    Check failure
        on line 37
        in src/Symfony/Component/ObjectMapper/Transform/MapCollection.php
  



  
      
View workflow job for this annotation

  

  
    
    GitHub Actions / Psalm
  

  
    
      NoValue
    
  

  
    src/Symfony/Component/ObjectMapper/Transform/MapCollection.php:37:13: NoValue: All possible types for this assignment were invalidated - This may be dead code (see https://psalm.dev/179)
             }
             return $value;
-          Expand Down