Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Serializer] Fix collect_denormalization_errors flag in defaultContext #60413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 6.4
Choose a base branch
Loading
from

Conversation

dmbrson
Copy link

@dmbrson dmbrson commented May 13, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59721
License MIT

When using the COLLECT_DENORMALIZATION_ERRORS flag during denormalization, Symfony should collect all errors and report them together in a PartialDenormalizationException.

Here is an example with two expected errors:

final readonly class Foo
{
    public function __construct(
        public string $bar,
        public \DateTimeInterface $createdAt,
    ) {}
}

$foo = $this->denormalizer->denormalize(
    data: ['createdAt' => ''],
    type: Foo::class,
);

Expected errors

  1. Failed to create object because the class misses the "bar" property.
  2. The data is either not a string, an empty string, or null; you should pass a string that can be parsed with the passed format or a valid DateTime string.

When the flag is passed via the context

$foo = $this->denormalizer->denormalize(
    data: ['createdAt' => ''],
    type: Foo::class,
    context: [
        DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS => true,
    ],
);

Both errors are correctly collected and returned.

When the flag is set via default_context in framework.yaml:

serializer:
    default_context:
        collect_denormalization_errors: true

Only one error is returned:
The data is either not a string, an empty string, or null; you should pass a string that can be parsed with the passed format or a valid DateTime string.

#Root Cause
The issue originates in the \src\Symfony\Component\Serializer\Serializer.php,
function normalize :

if (isset($context[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]) || isset($this->defaultContext[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS])) {
    unset($context[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]);
    $context['not_normalizable_value_exceptions'] = [];
    $errors = &$context['not_normalizable_value_exceptions'];
    $denormalized = $normalizer->denormalize($data, $type, $format, $context);
}

The first time this block is hit, it checks for the flag either in $context or $defaultContext. If found, it initializes the error array with:

    $context['not_normalizable_value_exceptions'] = [];

However, during nested denormalization (e.g., when parsing the createdAt field), Symfony re-enters this code path. If the flag was provided via defaultContext, it is still present on re-entry. Therefore, the not_normalizable_value_exceptions array is reset again, losing the previously collected errors.

#My Fix

The fix is to enhance the condition with an additional check to ensure the array of errors is not already initialized:

if (
    (isset($context[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]) || isset($this->defaultContext[DenormalizerInterface::COLLECT_DENORMALIZATION_ERRORS]))
    && !isset($context['not_normalizable_value_exceptions'])
)

This ensures the array is only initialized once, preserving previously collected errors in recursive calls, regardless of whether the flag was passed via context or default_context.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.