[Notifier] Allow to set block_id/value for SlackActionsBlock and SlackButtonBlockElement #60209
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for features / 6.4, 7.1, and 7.2 for bug fixes". Cheers! Carsonbot |
92d6fdb to
e687dff
Compare
…allow setting value in SlackButtonBlockElement
e687dff to
6c2d27e
Compare
| @@ -16,20 +16,27 @@ | ||
| */ | ||
| final class SlackButtonBlockElement extends AbstractSlackBlockElement | ||
| { | ||
| public function __construct(string $text, string $url, ?string $style = null) | ||
| public function __construct(string $text, ?string $url = null, ?string $style = null, ?string $value = null) |
There was a problem hiding this comment.
I'm not sure this change makes sense. Buttons defined this way are legacy anyway?
What would the value be used for, for buttons?
There was a problem hiding this comment.
According to slack API docs:
The value to send along with the interaction payload. Maximum length is 2000 characters.
If you want to react for a callback upon button is pressed, you can get a value of the button that was pressed, what can be hard without the value set.
There was a problem hiding this comment.
Simple example would be buttons like Approve & Decline that are included in one message - without the value, you can not determine which one was pressed by the user by just looking at the callback payload.
Allow to pass
nullas$urlforSlackActionsBlockas it is not requiredAllow to set
$valueas it is requiredAllow to set
block_idtoSlackActionsBlockas it is required