[Workflow] Add a link to mermaid.live from the profiler #60193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Workflow/DataCollector/WorkflowDataCollector.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Workflow/DataCollector/WorkflowDataCollector.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Workflow/DataCollector/WorkflowDataCollector.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Workflow/DataCollector/WorkflowDataCollector.php
Outdated
Show resolved
Hide resolved
cf57a8d to
b1c759e
Compare
nicolas-grekas
approved these changes
Apr 10, 2025
stof
reviewed
Apr 10, 2025
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/workflow.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Workflow/DataCollector/WorkflowDataCollector.php
Outdated
Show resolved
Hide resolved
b1c759e to
f28b4e3
Compare
stof
approved these changes
Apr 10, 2025
alexandre-daubois
approved these changes
Apr 11, 2025
src/Symfony/Component/Workflow/DataCollector/WorkflowDataCollector.php
Outdated
Show resolved
Hide resolved
f28b4e3 to
5082e72
Compare
fabpot
added a commit
that referenced
this pull request
May 2, 2025
…undle and the Workflow component (xabbuh) This PR was merged into the 7.3 branch. Discussion ---------- [WebProfilerBundle] fix compatibility between WebProfilerBundle and the Workflow component | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT related to #60193, the `buildMermaidLiveLink()` method used in the `workflow.html.twig` template requires 7.3+ of the Workflow component Commits ------- d7ab0fb fix compatibility between WebProfilerBundle and the Workflow component
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked, and there are no option to add a zoom feature with mermaid.js
We need another lib to do that.
So instead, let's add a link to mermaid.live, they will handle all the stuff for us
demo
mermaid.webm