Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Cache] ArrayAdapter serialization exception clean $expiries #60122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

[Cache] ArrayAdapter serialization exception clean $expiries #60122

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4bfce3
bug #60121[Cache] ArrayAdapter serialization exception clean $expiries
bastien-wink Apr 2, 2025
91331e1
Add tests
nicolas-grekas Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add tests
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Apr 7, 2025
commit 91331e1ae0ffac0c1ebfd9814e6add8aed215bee
13 changes: 13 additions & 0 deletions 13 src/Symfony/Component/Cache/Tests/Adapter/ArrayAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,17 @@ public function testEnum()

$this->assertSame(TestEnum::Foo, $cache->getItem('foo')->get());
}

public function testExpiryCleanupOnError()
{
$cache = new ArrayAdapter();

$item = $cache->getItem('foo');
$this->assertTrue($cache->save($item->set('bar')));
$this->assertTrue($cache->hasItem('foo'));

$item->set(static fn () => null);
$this->assertFalse($cache->save($item));
$this->assertFalse($cache->hasItem('foo'));
}
}
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.