symfony · vladimir-vv · Mar 26, 2025 · Apr 1, 2025 · xabbuh · May 3, 2025
@@ -565,7 +565,7 @@ private function renderCell(array $row, int $column, string $cellFormat): string

        // str_pad won't work properly with multi-byte strings, we need to fix the padding
        if (false !== $encoding = mb_detect_encoding($cell, null, true)) {
-            $width += \strlen($cell) - mb_strwidth($cell, $encoding);
+            $width += \strlen($cell) - mb_strwidth($cell, $encoding) + substr_count($cell, "\xef\xb8\x8f") + substr_count($cell, "\xef\xb8\x8e");
        }

        $style = $this->getColumnStyle($column);

@@ -2078,4 +2078,36 @@ public function testGithubIssue52101HorizontalFalse()
            $this->getOutputContent($output)
        );
    }
+
+    public function testGithubIssue60038WidthOfCellWithEmoji()
+    {
+        $table = (new Table($output = $this->getOutputStream()))
+            ->setHeaderTitle('Test Title')
+            ->setHeaders(['Title', 'Author'])
+            ->setRows([
+                ["🎭 💫 ☯"." Divine Comedy", "Dante Alighieri"],
+                // the snowflake (e2 9d 84 ef b8 8f) has a variant selector
+                ["👑 ❄️  🗡"." Game of Thrones", "George R.R. Martin"],
+                // the snowflake in text style (e2 9d 84 ef b8 8e) has a variant selector
+                ["❄︎❄︎❄︎ snowflake in text style ❄︎❄︎❄︎", ""],
+                ["And a very long line to show difference in previous lines", ""],
+            ])
+        ;
+        $table->render();
+
+        $this->assertSame(<<<TABLE
+---------------------------------- Test Title -------------+--------------------+
+| Title                                                     | Author             |
+-----------------------------------------------------------+--------------------+
+| 🎭 💫 ☯ Divine Comedy                                     | Dante Alighieri    |
+| 👑 ❄️  🗡 Game of Thrones                                   | George R.R. Martin |
+| ❄︎❄︎❄︎ snowflake in text style ❄︎❄︎❄︎                           |                    |
+| And a very long line to show difference in previous lines |                    |
+-----------------------------------------------------------+--------------------+
+
+TABLE
+            ,
+            $this->getOutputContent($output)
+        );
+    }
 }
-Original file line number
+Diff line change
@@ -565,7 +565,7 @@ private function renderCell(array $row, int $column, string $cellFormat): string
             // str_pad won't work properly with multi-byte strings, we need to fix the padding
             if (false !== $encoding = mb_detect_encoding($cell, null, true)) {
-                $width += \strlen($cell) - mb_strwidth($cell, $encoding);
+                $width += \strlen($cell) - mb_strwidth($cell, $encoding) + substr_count($cell, "\xef\xb8\x8f") + substr_count($cell, "\xef\xb8\x8e");
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            xabbuh
  

      

      

      


        May 3, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      What exactly does the unicode sequence \xef\xb8\x8e refer to?
    
  
  


    

        
      
  
    
  
  
  
    
    Sorry, something went wrong.
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



  
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      



      

  Author


  

  
    
      

      
            vladimir-vv
  

      

      

      


        May 5, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      These U+FE0F, U+FE0E selectors are used to display emoji with color or monochrome. As I can see usually the U+FE0E selector is skipped.

Example with snowflake:

U+2744	❄	e2 9d 84

U+2744	❄	e2 9d 84 ef b8 8e

U+2744	❄️	e2 9d 84 ef b8 8f
    
  
  


    

        
      
  
    
  
  
  
    
    Sorry, something went wrong.
  


          
      
  
    
    
      
        
            
    All reactions
             }
             $style = $this->getColumnStyle($column);
-          Expand Down