[Serializer] Fix ObjectNormalizer default context with named serializers #60026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e641ad to
6dde315
Compare
src/Symfony/Component/Serializer/DependencyInjection/SerializerPass.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Mar 24, 2025
mtarld
reviewed
Mar 24, 2025
src/Symfony/Component/Serializer/DependencyInjection/SerializerPass.php
Outdated
Show resolved
Hide resolved
HypeMC
commented
Mar 24, 2025
src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php
Outdated
Show resolved
Hide resolved
6dde315 to
80d993f
Compare
mtarld
reviewed
Mar 24, 2025
fabpot
approved these changes
Mar 26, 2025
mtarld
approved these changes
Mar 26, 2025
|
Thank you @HypeMC. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #59639, the main problem is that arguments have precedence over bindings, and children inherit arguments from their parents.
This PR moves the logic for setting the default context of
ObjectNormalizerfrom the extension to theSerializerPass, where only bindings are used.