[Lock] Add LockKeyNormalizer
#60023
Open
[Lock] Add LockKeyNormalizer
#60023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89d05b7 to
d1cd6e1
Compare
| { | ||
| $key = (new \ReflectionClass(Key::class))->newInstanceWithoutConstructor(); | ||
| foreach ($key->__sleep() as $serializedField) { | ||
| (fn () => $this->$serializedField = $data[$serializedField])->bindTo($key, Key::class)(); |
There was a problem hiding this comment.
it should be more efficient to have one closure outside of the loop instead of many calls inside
stof
reviewed
Mar 28, 2025
| $this->assertEqualsWithDelta($key->getRemainingLifetime(), $copy->getRemainingLifetime(), 0.001); | ||
| } | ||
|
|
||
| public function testDenormalize() |
There was a problem hiding this comment.
This test name as bad as this test is not covering denormalization at all.
| @@ -2128,6 +2129,11 @@ private function registerLockConfiguration(array $config, ContainerBuilder $cont | ||
| { | ||
| $loader->load('lock.php'); | ||
|
|
||
| // BC layer Lock < 7.3 | ||
| if (!class_exists(DenormalizerInterface::class) || !class_exists(LockKeyNormalizer::class)) { |
There was a problem hiding this comment.
Suggested change
| if (!class_exists(DenormalizerInterface::class) || !class_exists(LockKeyNormalizer::class)) { | |
| if (!interface_exists(DenormalizerInterface::class) || !class_exists(LockKeyNormalizer::class)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Lock documentation mentions that the lock keys are serializable – however, it seems that's the case only if you're using native php serializer.
I'm proposing to add
LockKeyNormalizerto make the example in the docs work the same when using Symfony Serializer too.