[DependencyInjection] Enable multiple attribute autoconfiguration callbacks on the same class #60011
Conversation
| return $configurators[0]; | ||
| } | ||
|
|
||
| return static function (...$args) use ($configurators) { |
There was a problem hiding this comment.
will this work when inspected by reflection?
There was a problem hiding this comment.
No, but the compiler pass uses the initial list of callbacks that is returned by the new getAttributeConfigurators() method instead of this.
This is only for backward compatibility if someone calls a callable returned by getAutoconfiguredAttributes(), which is deprecated.
There was a problem hiding this comment.
what about throwing instead? wouldn't this mimic the previous exception close enough?
| @@ -1448,7 +1447,7 @@ public function registerForAutoconfiguration(string $interface): ChildDefinition | ||
| */ | ||
| public function registerAttributeForAutoconfiguration(string $attributeClass, callable $configurator): void | ||
| { | ||
| $this->autoconfiguredAttributes[$attributeClass] = $configurator; | ||
| $this->autoconfiguredAttributes[$attributeClass][] = $configurator; |
There was a problem hiding this comment.
This is a behavior change: before, it was possible to call registerAttributeForAutoconfiguration() multiple times, replacing the previous configuration. With this change, they are added.
I don't know yet how to handle that, exempt if we allow multiple configurators only by merging.
…lbacks on the same class
|
Thank you @GromNaN. |
Replace #60001
By having a list of callables for each attributes, we can enable merging definitions each having an autoconfiguration for the same attribute class. This is the case with the
#[Entity]attribute in DoctrineBundle and FrameworkBundle.I have to deprecate
ContainerBuilder::getAutoconfiguredAttributes()as its return type isarray<class-string, callable>; so I added a new methodgetAttributeAutoconfigurationsthat returnsarray<class-string, callable[]>in in order to use reflection on each callable in the compiler pass.