[HttpFoundation] Add SessionHasFlashMessage test constraint #60008
Conversation
| { | ||
| public function __construct( | ||
| private readonly string $messageType, | ||
| private readonly string $message, |
There was a problem hiding this comment.
A message can be of any type (technically) https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/HttpFoundation/Session/Flash/FlashBagInterface.php#L31
For the matches() part this should use the Constraint comparator.
There was a problem hiding this comment.
A message is a string. The method set allows an array of strings. This constraint constructor looks good to me.
There was a problem hiding this comment.
My bad, referenced the wrong method. https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/HttpFoundation/Session/Flash/FlashBagInterface.php#L26
/**
* Adds a flash message for the given type.
*/
public function add(string $type, mixed $message): void;https://github.com/symfony/symfony/blob/7.3/src/Symfony/Component/HttpFoundation/Session/Flash/FlashBag.php#L83 (set() method implementation).
The set() method allows to set multiple messages for a type, but the type of a $message is mixed.
As it can also contain a Translatable object (Which I use in some projects), as long as there is a way to serialize the value, anything goes.
There was a problem hiding this comment.
Indeed, if a string is the common type for messages, nothing prevent from using anything else.
I found this thread where it is suggested to use a Markup object as message. Also, we can imagine that a Translatable object is used as well.
@Pierstoval would you mind to relax the message type?
| { | ||
| public function __construct( | ||
| private readonly string $messageType, | ||
| private readonly string $message, |
There was a problem hiding this comment.
A message is a string. The method set allows an array of strings. This constraint constructor looks good to me.
Eases the checks on the Session, to avoid the user having to do the checks themselves.
Before:
After: