[Messenger] Add --class-filter option to the messenger:failed:remove command
#59978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15bd310 to
8557685
Compare
|
class-filter sounds to much technical to me. What about message-filter ? |
chalasr
reviewed
Mar 24, 2025
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
|
@OskarStark |
be6573e to
fae8ce5
Compare
fabpot
approved these changes
Mar 24, 2025
| throw new RuntimeException('No failed messages were found with this filter.'); | ||
| } | ||
|
|
||
| if (!$io->confirm(\sprintf('There is %d message%s to remove. Do you want to continue?', $idsCount, $idsCount > 1 ? 's' : ''))) { |
There was a problem hiding this comment.
To avoid using is or are depending on the number of messages, let's rewrite it to something like:
Suggested change
| if (!$io->confirm(\sprintf('There is %d message%s to remove. Do you want to continue?', $idsCount, $idsCount > 1 ? 's' : ''))) { | |
| if (!$io->confirm(\sprintf('Can you confirm you want to remove %d message%s?', $idsCount, 1 === $idsCount ? '' : 's'))) { |
fae8ce5 to
1924719
Compare
|
Thank you @arnaud-deabreu. |
Merged
xabbuh
added a commit
that referenced
this pull request
Mar 24, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [Messenger] fix test | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | related to #59978 (comment) | License | MIT Commits ------- 0ec778b fix test
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 24, 2025
…ger:failed:remove` command (arnaud-deabreu) This PR was squashed before being merged into the 7.3 branch. Discussion ---------- [Messenger] Add `--class-filter` option to the `messenger:failed:remove` command | Q | A | ------------- | --- | Feature PR | symfony/symfony#59978 | PR author(s) | `@arnaud`-deabreu | Merged in | 7.3 | Doc issue | Fix #20805 The `--class-filter` was added in the `messenger:failed:remove` command in this [PR](symfony/symfony#59978). As the option already exists in the `messenger:failed:show` I'm wondering if only adding this example could be enough ? Commits ------- bdca4e9 [Messenger] Add `--class-filter` option to the `messenger:failed:remove` command
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--class-filterto themessenger:failed:removecommand which is already available onmessenger:failed:showcommand.It will yield the message ids that match the given class and use it as if it were passed as the
idargument in the command so the--forceand--show-messagescan work with this filter.When using the filter, the command will prompt for confirmation before removing the messages.
Example output: