-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[RateLimiter] Add CompoundRateLimiterFactory
#59929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Mar 12, 2025
mtarld
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With minor suggestion 🙂
src/Symfony/Component/RateLimiter/CompoundRateLimiterFactory.php
Outdated
Show resolved
Hide resolved
9dac513
to
aae5b46
Compare
CompoundRateLimiterFactory
CompoundRateLimiterFactory
fabpot
approved these changes
Mar 21, 2025
Thank you @kbond. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 8, 2025
…onfig (kbond) This PR was squashed before being merged into the 7.3 branch. Discussion ---------- [FrameworkBundle][RateLimiter] compound rate limiter config | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | yes | Issues | Fix #59925 | License | MIT Follow-up to #59929. Example: ```yaml framework: rate_limiter: two_per_minute: policy: 'fixed_window' limit: 2 interval: '1 minute' five_per_hour: policy: 'fixed_window' limit: 5 interval: '1 hour' lock_factory: null contact_form: policy: 'compound' limiters: [two_per_minute, five_per_hour] ``` ```php public function contactAction(RateLimiterFactoryInterface $contactFormLimiter) { // $contactFormLimiter is a CompoundRateLimiterFactory containing // "two_per_minute" & "five_per_hour" } ``` Commits ------- ee2a127 [FrameworkBundle][RateLimiter] compound rate limiter config
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for #59925.