Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DoctrineBridge] add new DatePointType Doctrine type #59900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 1 src/Symfony/Bridge/Doctrine/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ CHANGELOG

* Reset the manager registry using native lazy objects when applicable
* Deprecate the `DoctrineExtractor::getTypes()` method, use `DoctrineExtractor::getType()` instead
* Add support for `Symfony\Component\Clock\DatePoint` as `DatePointType` Doctrine type

7.2
---
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Bridge\Doctrine\DependencyInjection\CompilerPass;

use Symfony\Bridge\Doctrine\Types\DatePointType;
use Symfony\Component\Clock\DatePoint;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;

final class RegisterDatePointTypePass implements CompilerPassInterface
fabpot marked this conversation as resolved.
Show resolved Hide resolved
{
public function process(ContainerBuilder $container): void
{
if (!class_exists(DatePoint::class)) {
return;
}

if (!$container->hasParameter('doctrine.dbal.connection_factory.types')) {
return;
}

$types = $container->getParameter('doctrine.dbal.connection_factory.types');

$types['date_point'] ??= ['class' => DatePointType::class];

$container->setParameter('doctrine.dbal.connection_factory.types', $types);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Bridge\Doctrine\Tests\DependencyInjection\CompilerPass;

use PHPUnit\Framework\TestCase;
use Symfony\Bridge\Doctrine\DependencyInjection\CompilerPass\RegisterDatePointTypePass;
use Symfony\Bridge\Doctrine\Types\DatePointType;
use Symfony\Component\Clock\DatePoint;
use Symfony\Component\DependencyInjection\ContainerBuilder;

class RegisterDatePointTypePassTest extends TestCase
{
protected function setUp(): void
{
if (!class_exists(DatePoint::class)) {
self::markTestSkipped('The DatePoint class is not available.');
}
}

public function testRegistered()
{
$container = new ContainerBuilder();
nicolas-grekas marked this conversation as resolved.
Show resolved Hide resolved
$container->setParameter('doctrine.dbal.connection_factory.types', ['foo' => 'bar']);
(new RegisterDatePointTypePass())->process($container);

$expected = [
'foo' => 'bar',
'date_point' => ['class' => DatePointType::class],
];
$this->assertSame($expected, $container->getParameter('doctrine.dbal.connection_factory.types'));
}
}
85 changes: 85 additions & 0 deletions 85 src/Symfony/Bridge/Doctrine/Tests/Types/DatePointTypeTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Bridge\Doctrine\Tests\Types;

use Doctrine\DBAL\Platforms\AbstractPlatform;
use Doctrine\DBAL\Platforms\MariaDBPlatform;
use Doctrine\DBAL\Platforms\PostgreSQLPlatform;
use Doctrine\DBAL\Platforms\SqlitePlatform;
use Doctrine\DBAL\Types\ConversionException;
use Doctrine\DBAL\Types\Type;
use PHPUnit\Framework\TestCase;
use Symfony\Bridge\Doctrine\Types\DatePointType;
use Symfony\Component\Clock\DatePoint;

final class DatePointTypeTest extends TestCase
{
private DatePointType $type;

public static function setUpBeforeClass(): void
{
$name = DatePointType::NAME;
if (Type::hasType($name)) {
Type::overrideType($name, DatePointType::class);
} else {
Type::addType($name, DatePointType::class);
}
}

protected function setUp(): void
{
if (!class_exists(DatePoint::class)) {
self::markTestSkipped('The DatePoint class is not available.');
}
$this->type = Type::getType(DatePointType::NAME);
}

public function testDatePointConvertsToDatabaseValue()
{
$datePoint = new DatePoint('2025-03-03 12:13:14');

$expected = $datePoint->format('Y-m-d H:i:s');
$actual = $this->type->convertToDatabaseValue($datePoint, new PostgreSQLPlatform());

$this->assertSame($expected, $actual);
}

public function testDatePointConvertsToPHPValue()
{
$datePoint = new DatePoint();
$actual = $this->type->convertToPHPValue($datePoint, new SqlitePlatform());

$this->assertSame($datePoint, $actual);
}

public function testNullConvertsToPHPValue()
{
$actual = $this->type->convertToPHPValue(null, new SqlitePlatform());

$this->assertNull($actual);
}

public function testDateTimeImmutableConvertsToPHPValue()
{
$format = 'Y-m-d H:i:s';
$dateTime = new \DateTimeImmutable('2025-03-03 12:13:14');
$actual = $this->type->convertToPHPValue($dateTime, new SqlitePlatform());
$expected = DatePoint::createFromInterface($dateTime);

$this->assertSame($expected->format($format), $actual->format($format));
}

public function testGetName()
{
$this->assertSame('date_point', $this->type->getName());
}
}
44 changes: 44 additions & 0 deletions 44 src/Symfony/Bridge/Doctrine/Types/DatePointType.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Bridge\Doctrine\Types;

use Doctrine\DBAL\Platforms\AbstractPlatform;
use Doctrine\DBAL\Types\DateTimeImmutableType;
use Symfony\Component\Clock\DatePoint;

final class DatePointType extends DateTimeImmutableType
{
public const NAME = 'date_point';

/**
* @param T $value
*
* @return (T is null ? null : DatePoint)
*
* @template T
*/
public function convertToPHPValue(mixed $value, AbstractPlatform $platform): ?DatePoint
{
if (null === $value || $value instanceof DatePoint) {
derrabus marked this conversation as resolved.
Show resolved Hide resolved
return $value;
}

$value = parent::convertToPHPValue($value, $platform);

return DatePoint::createFromInterface($value);
}

public function getName(): string
{
return self::NAME;
}
}
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.