symfony · fabpot · Mar 3, 2025 · Mar 2, 2025 · xabbuh · Mar 2, 2025
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/Fixtures/WhenTestWithClosure.php b/src/Symfony/Component/Validator/Tests/Constraints/Fixtures/WhenTestWithClosure.php
@@ -11,13 +11,14 @@

 namespace Symfony\Component\Validator\Tests\Constraints\Fixtures;

+use Symfony\Component\Validator\Constraints\Callback;
 use Symfony\Component\Validator\Constraints\NotBlank;
 use Symfony\Component\Validator\Constraints\NotNull;
 use Symfony\Component\Validator\Constraints\When;

 #[When(expression: static function () {
        return true;
-    }, constraints: new NotNull()
+    }, constraints: new Callback('isValid')
 )]
 class WhenTestWithClosure
 {

diff --git a/src/Symfony/Component/Validator/Tests/Constraints/WhenTest.php b/src/Symfony/Component/Validator/Tests/Constraints/WhenTest.php
@@ -118,6 +118,8 @@ public function testAttributes()
     */
    public function testAttributesWithClosure()
    {
+        $this->markTestSkipped('Requires https://github.com/php/php-src/issues/17851 to be fixed');
+
        $loader = new AttributeLoader();
        $metadata = new ClassMetadata(WhenTestWithClosure::class);

@@ -129,7 +131,7 @@ public function testAttributesWithClosure()
        self::assertInstanceOf(\Closure::class, $classConstraint->expression);
        self::assertEquals([
            new Callback(
-                callback: 'callback',
+                callback: 'isValid',
                groups: ['Default', 'WhenTestWithClosure'],
            ),
        ], $classConstraint->constraints);
-Original file line number
+Diff line change
@@ -11,13 +11,14 @@
     namespace Symfony\Component\Validator\Tests\Constraints\Fixtures;
+    use Symfony\Component\Validator\Constraints\Callback;
     use Symfony\Component\Validator\Constraints\NotBlank;
     use Symfony\Component\Validator\Constraints\NotNull;
     use Symfony\Component\Validator\Constraints\When;
     #[When(expression: static function () {
             return true;
-        }, constraints: new NotNull()
             Copy link

  
      
    
  

  
      

  
  Member


      

  Author


  

  
    
      

      
            xabbuh
  

      

      

      


        Mar 2, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      
Symfony\Component\Validator\Exception\ConstraintDefinitionException: The constraint "Symfony\Component\Validator\Constraints\NotNull" cannot be put on classes.

    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
+        }, constraints: new Callback('isValid')
     )]
     class WhenTestWithClosure
     {
-          Expand Down