Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DoctrineBridge] fix compatibility with Doctrine ORM 4 #59887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 28, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Feb 28, 2025
@carsonbot carsonbot changed the title [DoctrineBridge] fix compatibility with Doctrine ORM 4 [DoctrineBridge] fix compatibility with Doctrine ORM 4 Feb 28, 2025
@xabbuh
Copy link
Member Author

xabbuh commented Feb 28, 2025

see doctrine/orm#11659

@xabbuh xabbuh force-pushed the doctrine-orm-11659 branch from e5c7dd1 to 97d564e Compare February 28, 2025 20:49
@xabbuh xabbuh force-pushed the doctrine-orm-11659 branch from 97d564e to 275c31f Compare February 28, 2025 20:55
@mtarld
Copy link
Contributor

mtarld commented Mar 1, 2025

Thank you @xabbuh.

@mtarld mtarld merged commit 31260d4 into symfony:6.4 Mar 1, 2025
6 of 11 checks passed
@xabbuh xabbuh deleted the doctrine-orm-11659 branch March 1, 2025 12:11
nicolas-grekas added a commit that referenced this pull request Mar 31, 2025
… < 8.4 (xabbuh)

This PR was merged into the 6.4 branch.

Discussion
----------

[DoctrineBridge] fix tests with Doctrine ORM 3.4+ on PHP < 8.4

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

The solution implemented in #59887 does no longer work on PHP < 8.4 with the changes made in doctrine/orm#11853.

Commits
-------

9be0d0a fix tests with Doctrine ORM 3.4+ on PHP < 8.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.