[FrameworkBundle] the DeduplicateMiddleware requires the lock feature to be enabled #59735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
983b77e to
aee6a0d
Compare
yceruto
approved these changes
Feb 8, 2025
a991bf2 to
659ed31
Compare
If the `lock` feature is not enabled, no `lock.factory` service will be registered.
| ['id' => 'handle_message', 'arguments' => [false]], | ||
| ], $container->getParameter('messenger.bus.events.middleware')); | ||
| $this->assertTrue($container->has('messenger.bus.queries')); | ||
| $this->assertSame([], $container->getDefinition('messenger.bus.queries')->getArgument(0)); |
There was a problem hiding this comment.
Let's convert all $this->assertSame([], ...) to assertEmpty() while at it maybe?
There was a problem hiding this comment.
this isn't the same - assertEmpty accepts zero or the empty string, null, etc
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
lockfeature is not enabled, nolock.factoryservice will be registered.