[HttpFoundation] Define PHPDoc type for Response::$statusTexts
#59373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jan 6, 2025
|
@nicolas-grekas Do you want I modify this PR to go to 7.3 or I can create a new one or something else? |
|
Nothing to do on your side, we'll do it while merging. |
GromNaN
approved these changes
Jan 6, 2025
OskarStark
approved these changes
Jan 6, 2025
xabbuh
approved these changes
Jan 6, 2025
As `Symfony\Component\HttpFoundation\Response::$statusTexts` is public, it can be used by everyone. Some of us can use type analysis like PSALM or PHPStan... It is always useful, and for some of them mandatory to have a proper array typing to use this variable.
|
Thank you @neilime. |
statusTexts
statusTextsResponse::$statusTexts
Response::$statusTextsResponse::$statusTexts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
Symfony\Component\HttpFoundation\Response::$statusTextsis public, it can be used by every projects. Some of them can use strict type analysis like PSALM or PHPStan...It is always useful, and for some of them mandatory to have a proper array typing to use this variable.