Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Cache] Update PhpFilesAdapter.php, remove goto statement #59266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

ywisax
Copy link
Contributor

@ywisax ywisax commented Dec 19, 2024

The goto statement can make the code's flow difficult to follow. PHP code is typically expected to have a more linear and understandable structure. For example, when using goto, it can jump from one part of the code to another in a non - sequential manner. This can lead to confusion for developers who are trying to understand the program's logic, especially in larger codebases.

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
License MIT

The goto statement can make the code's flow difficult to follow. PHP code is typically expected to have a more linear and understandable structure. For example, when using goto, it can jump from one part of the code to another in a non - sequential manner. This can lead to confusion for developers who are trying to understand the program's logic, especially in larger codebases.
@carsonbot carsonbot added this to the 6.4 milestone Dec 19, 2024
@derrabus derrabus changed the base branch from 6.4 to 7.3 December 19, 2024 18:46
@derrabus derrabus modified the milestones: 6.4, 7.3 Dec 19, 2024
@derrabus
Copy link
Member

This is not a bugfix, therefore I'm retargeting this PR to the 7.3 branch.

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we can avoid goto without adding complexity, let's do it.

@GromNaN GromNaN added the Cache label Dec 21, 2024
@carsonbot carsonbot changed the title Update PhpFilesAdapter.php, remove goto statement [Cache] Update PhpFilesAdapter.php, remove goto statement Dec 21, 2024
@GromNaN
Copy link
Member

GromNaN commented Dec 21, 2024

Thank you @ywisax.

@GromNaN GromNaN merged commit b23badd into symfony:7.3 Dec 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.