[JsonEncoder] Remove chunk size definition #59254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failures look related, could you check? |
|
Indeed, they're here because of the BC break between FrameworkBundle and JsonEncoder (because of the |
|
This will not disappear once merged. The CI failure are legitimate, because your PR misses the update of service definitions in FrameworkBundle to use the new signature. |
e782add to
8627499
Compare
|
It was missing my last update... Should be good then |
chalasr
approved these changes
Dec 21, 2024
GromNaN
approved these changes
Dec 21, 2024
|
Thank you Mathias. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
$forceEncodeChunksboolean.This boolean was telling if the encoder should use
json_encodeor should yield as small strings as possible.It was set to
falseby default and not easily configurable yet.This configurable behavior has been removed.
Instead, we use
json_encodedirectly if the value that does not contain any object. Otherwise, it'll be split (see the diff insrc/Symfony/Component/JsonEncoder/Tests/Fixtures/encoder/object_in_object.php)IMHO, this will fit most of the use cases, and remove a configuration complicated to understand.