Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

As I understand the issue with this solution is that since SIGALRM is global, if with a single messenger:consume I was consuming 2 keepalive transports which both set different keepalive intervals, it would not work as intended.

if with a single messenger:consume I was consuming 2 keepalive transports which both set different keepalive intervals, it would not work as intended.

With $minSeconds = min($minSeconds ?? $keepaliveInterval, $keepaliveInterval); we set a minimum value of all transports.
So if one transport return 5 seconds, other 10 seconds we set 5 seconds as interval.
I think this is great. If I set it manually via “--keepalive” I would also set the minimum of these values. And even if not, the proposed solution prefers “--keppalive” option so I can overwrite the values from transports at any time.

Could you go into more detail about the possible risks?