Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[FrameworkBundle] [JsonEncoder] Fix service definition #59179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Dec 11, 2024

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

The stack makes the CI fail, therefore this PR replaces $container->services()->stack() by a regular service decoration.

Of course, an issue must be created in order to make stack working in the Symfony CI.

@carsonbot carsonbot added this to the 7.3 milestone Dec 11, 2024
@carsonbot carsonbot changed the title [JsonEncoder] [FrameworkBundle] Fix service definition [FrameworkBundle] [JsonEncoder] Fix service definition Dec 11, 2024
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, worth investigating

@mtarld mtarld force-pushed the fix/json-encoder-stack branch from f058abf to 0d74921 Compare December 11, 2024 15:44
@mtarld
Copy link
Contributor Author

mtarld commented Dec 11, 2024

I created the related issue: #59186

@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2024

Thank you @mtarld.

@xabbuh xabbuh merged commit aa23093 into symfony:7.3 Dec 12, 2024
5 of 11 checks passed
@mtarld mtarld deleted the fix/json-encoder-stack branch December 12, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.