-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DoctrineBridge] Fix UniqueEntity
for non-integer identifiers
#59126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
UniqueEntity
for non-integer identifiers
@GiuseppeArcuti can you, now that there is a reproducer on the issue? |
8e1f62e
to
898174b
Compare
What should be done next here? Anyone up to help finish this PR? |
Either it should support symfony uid properly, or add an extension point to add custom equality checkers or some sort of callback option? |
No one tagged me.
This should resolve the issue in most cases.
@nicolas-grekas If the PR has been abandoned, what’s the procedure in that case? |
You can just open a new PR and reference this one and the issue, thanks |
Continued in #60275, thanks for the PR @GiuseppeArcuti |
…tifiers (GiuseppeArcuti, wkania) This PR was merged into the 7.2 branch. Discussion ---------- [DoctrineBridge] Fix UniqueEntityValidator Stringable identifiers | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #58883 | License | MIT `@GiuseppeArcuti` , thanks for creating the test in [PR](#59126). More info in the [comment](#59126 (comment)). Commits ------- b0f012f [DoctrineBridge] Fix UniqueEntityValidator Stringable identifiers 572ebe8 [DoctrineBridge] Fix UniqueEntity for non-integer identifiers
Failed to reproduce the issue reported in #58883