[Notifier] [Brevo][SMS] Brevo sms notifier add options #58786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch ">6.4". Cheers! Carsonbot |
|
Adding support for new options is a new feature, not a bugfix. So this should go in the next minor version, not in 6.4. |
|
oh! sorry! |
43e78b7 to
eb4db72
Compare
fabpot
approved these changes
Jan 5, 2025
eb4db72 to
1791f01
Compare
|
Thank you @ikerib. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used brevo-notifier and I realized that it was missing some options like the url address of the webhook, tags... I have added them.
I hope that I did well the pull request and everything related...