[Process] Return built-in cmd.exe commands directly in ExecutableFinder #58735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Seldaek
commented
Nov 2, 2024
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Refs #58734 |
| License | MIT |
nicolas-grekas
approved these changes
Nov 2, 2024
|
Thank you @Seldaek. |
xabbuh
reviewed
Nov 4, 2024
| } | ||
|
|
||
| $finder = new ExecutableFinder(); | ||
| $this->assertSame('rmdir', $finder->find('RMDIR')); |
There was a problem hiding this comment.
AppVeyor returns RMDIR but not rmdir (see the failing test). Do we need to fix the expectation here or is there still some flaw in the code?
There was a problem hiding this comment.
the command names are case insensitive so I guess the implementation is fine but test expectations should be fixed to match the input's case.
There was a problem hiding this comment.
👍 thanks for the feedback (see #58748 then)
This was referenced Nov 6, 2024
Merged
Merged
Merged
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.