Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Cache] recreate the schema for every single test #58578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 16, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

The former test implementation relied on the order in which tests are executed assuming that tests explicitly creating the schema were executed first. This assumption leads to test failures on PHPUnit 10+ were tests defined in parent classes are run first where they were run later with PHPUnit 9.6.

@carsonbot carsonbot added this to the 5.4 milestone Oct 16, 2024
@xabbuh xabbuh force-pushed the cache-doctrine-dbal-adapter-independent-tests branch from 89c04b6 to f9b4a58 Compare October 16, 2024 08:00
The former test implementation relied on the order in which tests are
executed assuming that tests explicitly creating the schema were executed
first. This assumption leads to test failures on PHPUnit 10+ were tests
defined in parent classes are run first where they were run later with
PHPUnit 9.6.
@xabbuh xabbuh force-pushed the cache-doctrine-dbal-adapter-independent-tests branch from f9b4a58 to 633a60e Compare October 17, 2024 14:03
@fabpot
Copy link
Member

fabpot commented Oct 18, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit 5b30bc6 into symfony:5.4 Oct 18, 2024
11 of 12 checks passed
@xabbuh xabbuh deleted the cache-doctrine-dbal-adapter-independent-tests branch October 18, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.